-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Puppet8x support #32
base: master
Are you sure you want to change the base?
Conversation
owner => $edit_uid, | ||
group => 0, | ||
mode => '0600', | ||
require => Package['trocla']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the idea to use the collector is that the collector can also be empty since there might be cases where you do not have the package installed.
} | ||
} | ||
Package<| title == 'trocla' |> -> file { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here with the collector
r = has_options ? store.send(trocla_func, key, format, options) : store.send(trocla_func, key, format) | ||
store.close | ||
r | ||
# Functions called from puppet manifests that look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason for the change in indentation?
Thank you, much appreciated! The collector statement is imho still necessary and it is still supported: https://www.puppet.com/docs/puppet/8/lang_collectors.html And other than that it would be greate to at least split the indentation changes into their own commit, since this makes it not so clear what are required changes for puppet 8 and what is (debatable) cosmetic changes. Any chance to get that at least splitted? |
The changes for Puppet8 mainly concern variable typing and legacy facts. |
No description provided.